fix: Simplify client naming conventions #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Jan 18, 2023
⏱️ Benchmark resultsComparing with 448232c
|
yevgenypats
approved these changes
Jan 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
🤖 I have created a release *beep* *boop* --- ## [1.28.0](v1.27.0...v1.28.0) (2023-01-23) ### Features * Add version discovery service ([#619](#619)) ([33ab32a](33ab32a)) * Dynamic tables and introduce proto versioning ([#610](#610)) ([448232c](448232c)) ### Bug Fixes * **clients:** Update `log line too long` message ([#611](#611)) ([0d3ff48](0d3ff48)) * Simplify client naming conventions ([#617](#617)) ([38b136b](38b136b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import paths and references will need to be updated after #610 anyway, let's use this opportunity to change from e.g.
destination.WithDestinationLogger(log.Logger)todestination.WithLogger(log.Logger)I will update the tests momentarily...done