feat(destination): Filter the duplicate primary keys prior to writing batch #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with 08bace8
|
candiduslynx
force-pushed
the
feat/destination/filter-out-duplicates
branch
from
edbf5ba to
51d151f
Compare
candiduslynx
force-pushed
the
feat/destination/filter-out-duplicates
branch
from
f15b5b5 to
fe2c3a6
Compare
hermanschaaf
approved these changes
Jan 26, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM, just minor comments around naming
disq
reviewed
Jan 26, 2023
yevgenypats
approved these changes
Jan 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [1.30.0](v1.29.0...v1.30.0) (2023-01-26) ### Features * **destination:** Filter the duplicate primary keys prior to writing batch ([#629](#629)) ([505709e](505709e)), closes [#627](#627) ### Bug Fixes * Ignore env variables in comments ([#625](#625)) ([08bace8](08bace8)) * Only call `newExecutionClient` if needed ([#630](#630)) ([ece947f](ece947f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #627