From f3d2917aae31badb849f595d5153e24ae5176dbf Mon Sep 17 00:00:00 2001 From: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com> Date: Sun, 12 Feb 2023 18:48:30 +0200 Subject: [PATCH] fix: Fix race in dest testing try 3 --- plugins/destination/plugin_testing.go | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/plugins/destination/plugin_testing.go b/plugins/destination/plugin_testing.go index db39cd6ec7..b3a994227c 100644 --- a/plugins/destination/plugin_testing.go +++ b/plugins/destination/plugin_testing.go @@ -82,6 +82,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestWriteOverwrite(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestWriteOverwriteDeleteStale", func(t *testing.T) { @@ -94,6 +97,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestWriteOverwriteDeleteStale(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestMigrateOverwrite", func(t *testing.T) { @@ -107,6 +113,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestMigrate(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestMigrateOverwriteForce", func(t *testing.T) { @@ -121,6 +130,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestMigrate(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestWriteAppend", func(t *testing.T) { @@ -133,6 +145,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestWriteAppend(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestMigrateAppend", func(t *testing.T) { @@ -146,6 +161,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestMigrate(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) t.Run("TestMigrateAppendForce", func(t *testing.T) { @@ -160,6 +178,9 @@ func PluginTestSuiteRunner(t *testing.T, newPlugin NewPluginFunc, spec any, test if err := suite.destinationPluginTestMigrate(ctx, p, logger, destSpec); err != nil { t.Fatal(err) } + if err := p.Close(ctx); err != nil { + t.Fatal(err) + } }) }