Skip to content

Conversation

@ClaudioGSDB
Copy link
Member

@ClaudioGSDB ClaudioGSDB commented Oct 17, 2025

Description

Improved the code-editor comnponents by adding an aria description to read out errors and warnings directly from the editor

Related links, issue #, if available:

  • AWSUI-61289

How has this been tested?

It was tested by using voice over to see if it was reading the description, also it was wrapped in different language context to see if it would also translate to other languages using i18n

go into the code editor component and see if it reads the errors and warnings when selecting the code editor itself (not the labels at the bottom)

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ClaudioGSDB ClaudioGSDB requested a review from a team as a code owner October 17, 2025 09:10
@ClaudioGSDB ClaudioGSDB requested review from mariksav and removed request for a team October 17, 2025 09:10
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (8584b2b) to head (5e45f97).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3945   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         854      854           
  Lines       24968    24973    +5     
  Branches     8793     8796    +3     
=======================================
+ Hits        24259    24264    +5     
+ Misses        702      660   -42     
- Partials        7       49   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ClaudioGSDB ClaudioGSDB added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@ClaudioGSDB ClaudioGSDB added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@ClaudioGSDB ClaudioGSDB added this pull request to the merge queue Oct 19, 2025
Merged via the queue into main with commit 041d9eb Oct 19, 2025
78 of 84 checks passed
@ClaudioGSDB ClaudioGSDB deleted the dev-v3-csciotto branch October 19, 2025 20:34
ClaudioGSDB added a commit that referenced this pull request Oct 20, 2025
Who-is-PS pushed a commit that referenced this pull request Oct 28, 2025
Co-authored-by: ClaudioGSDB <csciotto@amazon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants