Skip to content

Conversation

@Harsh-Anand-Singh
Copy link
Member

@Harsh-Anand-Singh Harsh-Anand-Singh commented Oct 29, 2025

Description

This PR provides the itemRemovedAriaLive string for AttributeEditor via the i18n provider, reducing friction for customers who previously had to manually provide this label.

The solution merges translated strings from the AWS-UI-Components-I18n package and provides the default announcement when no custom value is specified, while still allowing overrides through the i18nStrings prop. Additionally, the i18nStrings property documentation has been improved to clearly list all available localized strings with descriptions.

Related links, issue #, if available: AWSUI-61133

How has this been tested?

I've tested the i18n integration:

  • Modified the attribute-editor simple page locally to wrap the component with I18nProvider to enable i18n functionality
  • Verified that the component without explicit itemRemovedAriaLive now receives the default i18n value
  • Confirmed that explicit i18nStrings.itemRemovedAriaLive values continue to override the default
  • Tested with a screen reader to verify the removal announcement is properly announced
  • Verified the i18n integration works correctly by adding unit tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (05d1e35) to head (63a7cd8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3985   +/-   ##
=======================================
  Coverage   97.18%   97.19%           
=======================================
  Files         858      858           
  Lines       25345    25350    +5     
  Branches     9004     9007    +3     
=======================================
+ Hits        24632    24638    +6     
+ Misses        664      663    -1     
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harsh-Anand-Singh Harsh-Anand-Singh force-pushed the i18n-improvements-attributeeditor branch 2 times, most recently from 5358a60 to d2fd3d1 Compare October 31, 2025 11:24
@Harsh-Anand-Singh Harsh-Anand-Singh added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 6393a71 Nov 3, 2025
49 checks passed
@Harsh-Anand-Singh Harsh-Anand-Singh deleted the i18n-improvements-attributeeditor branch November 3, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants