generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 204
feat: add i18n support for itemRemovedAriaLive in attribute-editor #3985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
=======================================
Coverage 97.18% 97.19%
=======================================
Files 858 858
Lines 25345 25350 +5
Branches 9004 9007 +3
=======================================
+ Hits 24632 24638 +6
+ Misses 664 663 -1
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgylobko
reviewed
Oct 31, 2025
5358a60 to
d2fd3d1
Compare
georgylobko
reviewed
Oct 31, 2025
georgylobko
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides the
itemRemovedAriaLivestring for AttributeEditor via the i18n provider, reducing friction for customers who previously had to manually provide this label.The solution merges translated strings from the AWS-UI-Components-I18n package and provides the default announcement when no custom value is specified, while still allowing overrides through the
i18nStringsprop. Additionally, thei18nStringsproperty documentation has been improved to clearly list all available localized strings with descriptions.Related links, issue #, if available: AWSUI-61133
How has this been tested?
I've tested the i18n integration:
I18nProviderto enable i18n functionalityitemRemovedAriaLivenow receives the default i18n valuei18nStrings.itemRemovedAriaLivevalues continue to override the defaultReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.