Skip to content

Conversation

@gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Oct 30, 2025

This reverts commit 2935dd6.

Description

Reverting change that caused unexpected difference to input hover states (e.g. when also in invalid state)

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster marked this pull request as ready for review October 30, 2025 14:25
@gethinwebster gethinwebster requested a review from a team as a code owner October 30, 2025 14:25
@gethinwebster gethinwebster requested review from jperals and removed request for a team October 30, 2025 14:25
package.json Outdated
"path": "lib/components/internal/widget-exports.js",
"brotli": false,
"limit": "977 kB",
"limit": "976 kB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would increase that just in case - otherwise there is a chance it will fail after merging to main

georgylobko
georgylobko previously approved these changes Oct 30, 2025
pan-kot
pan-kot previously approved these changes Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (da2f215) to head (c852a6a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3990      +/-   ##
==========================================
- Coverage   97.18%   97.18%   -0.01%     
==========================================
  Files         858      857       -1     
  Lines       25345    25303      -42     
  Branches     9004     8968      -36     
==========================================
- Hits        24632    24590      -42     
  Misses        664      664              
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster gethinwebster added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit f44f577 Oct 30, 2025
49 checks passed
@gethinwebster gethinwebster deleted the input-revert branch October 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants