Skip to content

Conversation

@georgylobko
Copy link
Member

Description

Add an additional check to props-merger if global drawers have at least one item with a trigger

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (a59c74f) to head (c0924c3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4000   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files         858      858           
  Lines       25359    25362    +3     
  Branches     9014     9016    +2     
=======================================
+ Hits        24650    24653    +3     
- Misses        660      703   +43     
+ Partials       49        6   -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add a test on a triggerless drawer behavior?

mxschll
mxschll previously approved these changes Nov 3, 2025
@georgylobko georgylobko added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 0a448ad Nov 3, 2025
84 of 85 checks passed
@georgylobko georgylobko deleted the fix/toolbar-with-triggerless-global-drawers branch November 3, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants