Skip to content

Conversation

@jorycunningham
Copy link
Contributor

Description

This PR changes the outer element of the Internal Input to a span, rather than a div to ensure that when nested in a span (as in the Text Filter Component) that the HTML remains valid.

Note: the element already had display:flex applied so no changes needed to preserve box layout

Addresses AWSUI-20178

How has this been tested?

Tested manually with local build, visual regression

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md._
  • Changes do not include unsupported browser features, see CONTRIBUTING.md._
  • Changes were manually tested for accessibility, see accessibility guidelines._

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jorycunningham jorycunningham requested a review from a team as a code owner January 20, 2023 16:20
@jorycunningham jorycunningham requested review from avinashbot and johannes-weber and removed request for a team and johannes-weber January 20, 2023 16:20
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 92.60% // Head: 92.97% // Increases project coverage by +0.36% 🎉

Coverage data is based on head (2632be4) compared to base (2ac7599).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   92.60%   92.97%   +0.36%     
==========================================
  Files         559      574      +15     
  Lines       15811    16766     +955     
  Branches     4327     4628     +301     
==========================================
+ Hits        14642    15588     +946     
- Misses       1087     1101      +14     
+ Partials       82       77       -5     
Impacted Files Coverage Δ
src/input/internal.tsx 100.00% <100.00%> (ø)
src/breadcrumb-group/item/item.tsx 42.85% <0.00%> (-57.15%) ⬇️
src/table/resizer/index.tsx 83.51% <0.00%> (-16.49%) ⬇️
src/flashbar/index.tsx 53.94% <0.00%> (-10.06%) ⬇️
src/split-panel/icons/bottom-icon-refresh.tsx 33.33% <0.00%> (-9.53%) ⬇️
src/split-panel/icons/side-position-refresh.tsx 36.36% <0.00%> (-8.09%) ⬇️
src/internal/hooks/use-focus-tracker.ts 92.30% <0.00%> (-7.70%) ⬇️
src/hotspot/index.tsx 95.00% <0.00%> (-5.00%) ⬇️
src/wizard/wizard-actions.tsx 92.00% <0.00%> (-4.00%) ⬇️
src/autosuggest/utils/utils.ts 96.00% <0.00%> (-4.00%) ⬇️
... and 212 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorycunningham jorycunningham changed the title change input container wrapper to span tag Improve HTML validity of Internal Inputs in TextFilter Jan 20, 2023
@jorycunningham jorycunningham changed the title Improve HTML validity of Internal Inputs in TextFilter fix: Improve HTML validity of Internal Inputs in TextFilter Jan 20, 2023
Copy link
Member

@avinashbot avinashbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants