Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_cloudformation_stack resource #1022

Merged
merged 2 commits into from Sep 16, 2021
Merged

Add aws_cloudformation_stack resource #1022

merged 2 commits into from Sep 16, 2021

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Sep 8, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation yes

Description

New AWS resource aws_cloudformation_stack

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1022 (430c69b) into main (27a6c06) will decrease coverage by 0.04%.
The diff coverage is 69.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   81.53%   81.49%   -0.05%     
==========================================
  Files         242      245       +3     
  Lines        7870     7932      +62     
==========================================
+ Hits         6417     6464      +47     
- Misses       1255     1267      +12     
- Partials      198      201       +3     
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
...remote/aws/repository/cloudformation_repository.go 66.66% <66.66%> (ΓΈ)
pkg/resource/aws/aws_cloudformation_stack.go 72.72% <72.72%> (ΓΈ)
pkg/remote/aws/cloudformation_stack_enumerator.go 75.86% <75.86%> (ΓΈ)
pkg/resource/aws/metadatas.go 100.00% <100.00%> (ΓΈ)
pkg/resource/resource.go 83.43% <0.00%> (+2.45%) ⬆️

@wbeuil wbeuil force-pushed the res/cfn-stack branch 2 times, most recently from 6c5924f to 7e9056b Compare September 15, 2021 11:04
eliecharra
eliecharra previously approved these changes Sep 16, 2021
@eliecharra eliecharra merged commit ce80b1d into main Sep 16, 2021
@eliecharra eliecharra deleted the res/cfn-stack branch September 16, 2021 12:05
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants