fix: autofix invalid escape sequences with ruff#60
Merged
chrisimcevoy merged 2 commits intoNov 26, 2024
Conversation
lskillen
approved these changes
Oct 17, 2024
Member
lskillen
left a comment
lskillen
left a comment
There was a problem hiding this comment.
Cool. :) We should probably just let ruff do its thing generally after this, and perhaps run it automatically as part of the code generation process. 😁
Contributor
Author
That would be nice, but I kept it this way for now as there might be some ruff rules we wish to enable in future which cannot be automatically fixed... let's have a chat about it! |
chrisimcevoy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in cloudsmith-io/cloudsmith-cli#167
The generated Python bindings fire a tonne of invalid escape sequence warnings in modern interpreters.
This PR uses ruff via pre-commit to autofix those.
Verified that this fails in CirecleCI when pre-commit hooks haven't been run: