feat(eng-2374): Add policy package query string#118
Merged
Conversation
Leeoc
force-pushed
the
eng-2374/policy-package-search-string-cli
branch
from
4ffe4d1 to
629abe7
Compare
Leeoc
force-pushed
the
eng-2374/policy-package-search-string-cli
branch
from
629abe7 to
b78ed8f
Compare
Leeoc
commented
May 17, 2023
Collaborator
|
I wonder do we need to start worrying about the length of some of these values when "pretty" printing. Thinking if someone had a particularly cumbersome package_query_string, or a boatload of spdx_identifiers in a license policy? For non-pretty output, we should show it all though. |
chrisimcevoy
requested changes
May 17, 2023
|
Code Climate has analyzed commit 12ab94f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.9% (0.1% change). View more on Code Climate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
package_query_stringto the existing license and vulnerability policy CLI's