Skip to content

fix(ENG-7593): Update CLI so login command can handle 2FA verification#188

Merged
jmccayCS merged 17 commits into
masterfrom
ENG-6145/2fa-users-must-pass-2fa-to-login
Apr 23, 2025
Merged

fix(ENG-7593): Update CLI so login command can handle 2FA verification#188
jmccayCS merged 17 commits into
masterfrom
ENG-6145/2fa-users-must-pass-2fa-to-login

Conversation

@jmccayCS
Copy link
Copy Markdown
Contributor

@jmccayCS jmccayCS commented Mar 21, 2025

What?

Why?

  • This was a security concern before, raised by a customer. Customer's were concerned that logging in via the CLI allowed users to retrieve their API key and login, totally bypassing their account setting requiring 2FA authentication.

Copy link
Copy Markdown
Contributor

@mhutchings-182 mhutchings-182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it all LGTM but just a few questions!

Comment thread cloudsmith_cli/cli/commands/login.py
Comment thread cloudsmith_cli/cli/commands/login.py
Copy link
Copy Markdown
Contributor

@mhutchings-182 mhutchings-182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmccayCS jmccayCS merged commit c7be490 into master Apr 23, 2025
12 checks passed
@jmccayCS jmccayCS deleted the ENG-6145/2fa-users-must-pass-2fa-to-login branch April 23, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants