Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some paths that were missing on Windows #79

Merged
merged 3 commits into from Feb 16, 2019

Conversation

@budden
Copy link
Contributor

commented Feb 11, 2019

Please see #42

Copy link
Owner

left a comment

I don't have a proper way to check on windows but I see that it's working fine on linux.

install.sh Outdated
@@ -0,0 +1,31 @@
# Don't run this one directly, use «make install» to run it

This comment has been minimized.

Copy link
@cloudson

cloudson Feb 14, 2019

Owner

Can you set a shell here? Codacy is also reporting it as an error.

This comment has been minimized.

Copy link
@budden

budden Feb 14, 2019

Author Contributor

Set bash. However I have no linux at hand now to check if it will still work w/o shell variables which are set in the Makefile. It should, but no 100% confidence.

@cloudson cloudson merged commit cb2cec9 into cloudson:develop Feb 16, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cloudson

This comment has been minimized.

Copy link
Owner

commented Feb 16, 2019

Thank you so much @budden :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.