Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup of base url in CloudStoreRestClient needs to be reversed #48

Open
wwilk opened this issue May 25, 2015 · 0 comments
Open

Lookup of base url in CloudStoreRestClient needs to be reversed #48

wwilk opened this issue May 25, 2015 · 0 comments
Assignees
Labels

Comments

@wwilk
Copy link
Contributor

@wwilk wwilk commented May 25, 2015

Currently we are looking for base URL of the server, by taking request URL, adding "/_test" at the end of it and calling the server. If the call is mapped to one of the methods in TestService then this method returns "SUCCESS" and base URL is found, otherwise we remove the last part of the request URL, and repeat the whole process again.

Example:
For request URL - "https://localhost:4663/aaa/bbb/ccc/" and base URL "https://localhost:4663/" we have following calls :

We should reverse this lookup, because it is allowed right now to have a directory with name "_test". Although request for this directory wouldn't return "TEXT_PLAIN" like call to TestService methods, but it can change in the future, when we have an exploring of repository in browser.
Only case, in which we would have problems with reversed approach, would be if there's a valid ".../_test" URL outside of the scope of our application (and actually above our applications root-URL).

Example:
If base URL is "htts://cloudstore.codewizards.co/mediathek" and there is a valid URL "https://cloudstore.codewizards.co/_test" outside the application.

This is much less likely than directory named "_test", but still it should be documented when we allow users to deploy cloudstore as a WAR.

@wwilk wwilk added the enhancement label May 25, 2015
@wwilk wwilk self-assigned this May 25, 2015
wwilk added a commit that referenced this issue May 26, 2015
wwilk added a commit that referenced this issue May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.