New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Long.MIN_VALUE as null-masking-value #81

Open
nlmarco opened this Issue Aug 24, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@nlmarco
Contributor

nlmarco commented Aug 24, 2018

For consistency with subshare/subshare#71 we should switch from -1 to Long.MIN_VALUE.

@nlmarco nlmarco added the enhancement label Aug 24, 2018

@nlmarco nlmarco self-assigned this Aug 24, 2018

@nlmarco nlmarco modified the milestones: 0.10.5, 0.10.6 Aug 24, 2018

nlmarco added a commit that referenced this issue Aug 24, 2018

@nlmarco

This comment has been minimized.

Contributor

nlmarco commented Aug 24, 2018

We should not change to Long.MIN_VALUE everywhere, because it's too invasive and not necessary. Only change the properties related to subshare/subshare#71 and things that are semantically related.

nlmarco added a commit that referenced this issue Aug 24, 2018

nlmarco added a commit that referenced this issue Aug 24, 2018

nlmarco added a commit that referenced this issue Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment