New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EMR Resources #412

Closed
alonsodomin opened this Issue Mar 2, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@alonsodomin
Contributor

alonsodomin commented Mar 2, 2016

CloudFormation just recently added support for EMR resources:
https://aws.amazon.com/about-aws/whats-new/2016/02/aws-cloudformation-adds-support-for-amazon-vpc-nat-gateway-amazon-ec2-container-registry-and-more/

It has happened this latest addition to CloudFormation was added in the moment that me and my colleagues were actually experimenting with it using CloudFormation CustomResources and Lambda Functions.

Adding pure "native" support sounds simpler though and we already have prototyped something extending Troposphere AWSObject & AWSProperty base objects. We are happy to PR it if no one else is working on it

@phobologic

This comment has been minimized.

Show comment
Hide comment
@phobologic

phobologic Mar 3, 2016

Member

We have no current pull requests, and I haven't heard of anyone working on it yet, so if you want to submit a PR that'd be great! Thanks.

Member

phobologic commented Mar 3, 2016

We have no current pull requests, and I haven't heard of anyone working on it yet, so if you want to submit a PR that'd be great! Thanks.

@alonsodomin

This comment has been minimized.

Show comment
Hide comment
@alonsodomin

alonsodomin Mar 3, 2016

Contributor

Cool, will try to get some unit tests for the new objects and properties and then make the PR, feel free to assign this issue to me

Contributor

alonsodomin commented Mar 3, 2016

Cool, will try to get some unit tests for the new objects and properties and then make the PR, feel free to assign this issue to me

@phobologic

This comment has been minimized.

Show comment
Hide comment
@phobologic

phobologic Mar 3, 2016

Member

Great, thanks @alonsodomin

Member

phobologic commented Mar 3, 2016

Great, thanks @alonsodomin

@phobologic

This comment has been minimized.

Show comment
Hide comment
@phobologic

phobologic Mar 3, 2016

Member

btw, instead of writing unit tests, we like to add an example to examples. The test suite will automatically run all examples and compare the output to the templates in tests/examples_output. This would probably be a good one:

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-emr-cluster.html#d0e52177

Member

phobologic commented Mar 3, 2016

btw, instead of writing unit tests, we like to add an example to examples. The test suite will automatically run all examples and compare the output to the templates in tests/examples_output. This would probably be a good one:

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-emr-cluster.html#d0e52177

@alonsodomin

This comment has been minimized.

Show comment
Hide comment
@alonsodomin

alonsodomin Apr 5, 2016

Contributor

Just realised right now (after receiving an AWS announcement email) that now CloudFormation supports EBS volumes in the EMR resources... should have included those in the initial PR. Will try to get some come working in the next hours and submit a new PR if here are happy with it:

https://aws.amazon.com/about-aws/whats-new/2016/03/aws-cloudformation-updates-amazon-s3-aws-lambda-and-amazon-emr-resources-support/?sc_channel=em&sc_campaign=releasenotes&sc_publisher=aws&sc_medium=em_13165&sc_content=launch&sc_country=mult&sc_geo=mult&sc_category=20160404_releasenotes&mkt_tok=3RkMMJWWfF9wsRonuK3Pd%2B%2FhmjTEU5z16OspWaKxgIkz2EFye%2BLIHETpodcMTcNmM7rYDBceEJhqyQJxPr3ELdINzs9wRhbkDg%3D%3D

Contributor

alonsodomin commented Apr 5, 2016

Just realised right now (after receiving an AWS announcement email) that now CloudFormation supports EBS volumes in the EMR resources... should have included those in the initial PR. Will try to get some come working in the next hours and submit a new PR if here are happy with it:

https://aws.amazon.com/about-aws/whats-new/2016/03/aws-cloudformation-updates-amazon-s3-aws-lambda-and-amazon-emr-resources-support/?sc_channel=em&sc_campaign=releasenotes&sc_publisher=aws&sc_medium=em_13165&sc_content=launch&sc_country=mult&sc_geo=mult&sc_category=20160404_releasenotes&mkt_tok=3RkMMJWWfF9wsRonuK3Pd%2B%2FhmjTEU5z16OspWaKxgIkz2EFye%2BLIHETpodcMTcNmM7rYDBceEJhqyQJxPr3ELdINzs9wRhbkDg%3D%3D

@alonsodomin

This comment has been minimized.

Show comment
Hide comment
@alonsodomin

alonsodomin Apr 14, 2016

Contributor

Closing this off after the merge of #453

Contributor

alonsodomin commented Apr 14, 2016

Closing this off after the merge of #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment