From b40648231d526edc8a2106bdcdb245745a0301d9 Mon Sep 17 00:00:00 2001
From: Laurent Pages <laurent.pages@elca.ch>
Date: Thu, 18 Apr 2019 16:42:00 +0200
Subject: [PATCH] add missing tests for the endpoint layer

---
 pkg/management/endpoint.go      |  4 +-
 pkg/management/endpoint_test.go | 67 +++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 2 deletions(-)

diff --git a/pkg/management/endpoint.go b/pkg/management/endpoint.go
index 5d6cbba2..7a8c26a3 100644
--- a/pkg/management/endpoint.go
+++ b/pkg/management/endpoint.go
@@ -326,10 +326,10 @@ func MakeUpdateRealmCustomConfigurationEndpoint(managementComponent ManagementCo
 	return func(ctx context.Context, req interface{}) (interface{}, error) {
 		var m = req.(map[string]string)
 
-		roleJson := []byte(m["body"])
+		configJson := []byte(m["body"])
 
 		var customConfig api.RealmCustomConfiguration
-		err := json.Unmarshal(roleJson, &customConfig)
+		err := json.Unmarshal(configJson, &customConfig)
 		if err != nil {
 			return nil, err
 		}
diff --git a/pkg/management/endpoint_test.go b/pkg/management/endpoint_test.go
index 2935f3e8..c6801c10 100644
--- a/pkg/management/endpoint_test.go
+++ b/pkg/management/endpoint_test.go
@@ -655,3 +655,70 @@ func TestCreateClientRoleEndpoint(t *testing.T) {
 		assert.NotNil(t, err)
 	}
 }
+
+func TestGetRealmCustomConfigurationEndpoint(t *testing.T) {
+	var mockCtrl = gomock.NewController(t)
+	defer mockCtrl.Finish()
+
+	var mockManagementComponent = mock.NewManagementComponent(mockCtrl)
+
+	var e = MakeGetRealmCustomConfigurationEndpoint(mockManagementComponent)
+
+	// No error
+	{
+		var realmName = "master"
+		var clientID = "123456"
+		var ctx = context.Background()
+		var req = make(map[string]string)
+		req["realm"] = realmName
+		req["clientID"] = clientID
+
+		mockManagementComponent.EXPECT().GetRealmCustomConfiguration(ctx, realmName).Return(api.RealmCustomConfiguration{}, nil).Times(1)
+		var res, err = e(ctx, req)
+		assert.Nil(t, err)
+		assert.NotNil(t, res)
+	}
+}
+
+func TestUpdateRealmCustomConfigurationEndpoint(t *testing.T) {
+	var mockCtrl = gomock.NewController(t)
+	defer mockCtrl.Finish()
+
+	var mockManagementComponent = mock.NewManagementComponent(mockCtrl)
+
+	var e = MakeUpdateRealmCustomConfigurationEndpoint(mockManagementComponent)
+
+	// No error
+	{
+		var realmName = "master"
+		var clientID = "123456"
+		var configJSON = "{\"DefaultClientId\":\"clientId\", \"DefaultRedirectUri\":\"http://cloudtrust.io\"}"
+		var ctx = context.Background()
+		var req = make(map[string]string)
+		req["realm"] = realmName
+		req["clientID"] = clientID
+		req["body"] = configJSON
+
+		mockManagementComponent.EXPECT().UpdateRealmCustomConfiguration(ctx, realmName, gomock.Any()).Return(nil).Times(1)
+		var res, err = e(ctx, req)
+		assert.Nil(t, err)
+		assert.Nil(t, res)
+	}
+
+	// JSON error
+	{
+		var realmName = "master"
+		var clientID = "123456"
+		var configJSON = "{\"DefaultClientId\":\"clientId\", \"DefaultRedirectUri\":\"http://cloudtrust.io\""
+		var ctx = context.Background()
+		var req = make(map[string]string)
+		req["realm"] = realmName
+		req["clientID"] = clientID
+		req["body"] = configJSON
+
+		mockManagementComponent.EXPECT().UpdateRealmCustomConfiguration(ctx, realmName, gomock.Any()).Return(nil).Times(0)
+		var res, err = e(ctx, req)
+		assert.NotNil(t, err)
+		assert.Nil(t, res)
+	}
+}