Merge pull request #114 from looffee/master

[Android] Fix 'createIceServer' method Invalid value error
flutter-webrtc · Aug 12, 2019 · dd6edbe · dd6edbe
2 parents 3cf1aaa + aec5477
commit dd6edbe
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/android/src/main/java/com/cloudwebrtc/webrtc/FlutterWebRTCPlugin.java b/android/src/main/java/com/cloudwebrtc/webrtc/FlutterWebRTCPlugin.java
@@ -434,14 +434,22 @@ private List<PeerConnection.IceServer> createIceServers(ConstraintsArray iceServ
                         break;
                     case Array:
                         ConstraintsArray urls = iceServerMap.getArray("urls");
+                        List<String> urlsList = new ArrayList<>();
+
                         for (int j = 0; j < urls.size(); j++) {
-                            String url = urls.getString(j);
-                            if (hasUsernameAndCredential) {
-                                iceServers.add(PeerConnection.IceServer.builder(iceServerMap.getString(url)).setUsername(iceServerMap.getString("username")).setPassword(iceServerMap.getString("credential")).createIceServer());
-                            } else {
-                                iceServers.add(PeerConnection.IceServer.builder(url).createIceServer());
-                            }
+                            urlsList.add(urls.getString(j));
                         }
+
+                        PeerConnection.IceServer.Builder builder = PeerConnection.IceServer.builder(urlsList);
+
+                        if (hasUsernameAndCredential) {
+                            builder
+                                    .setUsername(iceServerMap.getString("username"))
+                                    .setPassword(iceServerMap.getString("credential"));
+                        }
+
+                        iceServers.add(builder.createIceServer());
+
                         break;
                 }
             }