Skip to content

Comments

WIP: feat(generic): add binarypb generics#1484

Closed
jieqiboh wants to merge 7 commits intocloudwego:developfrom
jieqiboh:binarypbgeneric
Closed

WIP: feat(generic): add binarypb generics#1484
jieqiboh wants to merge 7 commits intocloudwego:developfrom
jieqiboh:binarypbgeneric

Conversation

@jieqiboh
Copy link
Contributor

@jieqiboh jieqiboh commented Aug 7, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Make binarypbgenerics forward entire payload with metainfo included.
Also add additional tests for a normal server and biz error scenario.
@jieqiboh jieqiboh requested review from a team as code owners August 7, 2024 06:30
@YangruiEmma
Copy link
Member

sorry for missing the pr~ Is this pr related to issue #1229, if it is, I think it doesn't meet task requirement

@YangruiEmma
Copy link
Member

if if for kitex protobuf protocol, I don't think we need one more BinaryCodec to do it, only modifying the binarythrift_codec is enough, because the rpc message protocol definition of kitex protobuf is same with Thrift.

But our usage document does not provide sufficient explanation on this, and we need to make some supplements for kitex protobuf later

@YangruiEmma
Copy link
Member

Thanks for your contribution @jieqiboh , I will close it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants