WIP: feat(generic): add binarypb generics#1484
Closed
jieqiboh wants to merge 7 commits intocloudwego:developfrom
Closed
WIP: feat(generic): add binarypb generics#1484jieqiboh wants to merge 7 commits intocloudwego:developfrom
jieqiboh wants to merge 7 commits intocloudwego:developfrom
Conversation
Make binarypbgenerics forward entire payload with metainfo included. Also add additional tests for a normal server and biz error scenario.
Member
|
sorry for missing the pr~ Is this pr related to issue #1229, if it is, I think it doesn't meet task requirement |
Member
|
if if for kitex protobuf protocol, I don't think we need one more BinaryCodec to do it, only modifying the binarythrift_codec is enough, because the rpc message protocol definition of kitex protobuf is same with Thrift. But our usage document does not provide sufficient explanation on this, and we need to make some supplements for kitex protobuf later |
Member
|
Thanks for your contribution @jieqiboh , I will close it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: