Updates #18
Merged
Updates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the versions in the requirements file, removes unneeded imports in test files and makes a small change so we don't need test-utils anymore.
Moving these to the base makes it way easier to configure tower.
For example, instead of this:
DOMAIN_METHODS = {
'messages': [
('fjord/**.py', 'tower.management.commands.extract.extract_tower_python'),
]
}
we can do this:
DOMAIN_METHODS = {
'messages': [
('fjord/**.py', 'tower.extract_tower_python'),
]
}
I added an import to tower.management.commands.extract so that older
tower configurations continue to work.
This documents tower. There's probably some things missing, but it'll make people (aka me) much happier.
|
I just noticed there are two pull requests that have been around for many LDAP password resets. Please don't let this one languish in pull request purgatory forever. It doesn't change any functionality. It's backwards compatible with existing projects. Help me tower maintainers. You are my only hope. |
| * Jinja2 and Jingo | ||
| * translate-toolkit | ||
|
|
||
| See requirements.txt for details. |
There was a problem hiding this comment.
You could have linked to it!
There was a problem hiding this comment.
Oh... you're right. I'll do another pr for that.
davedash
added a commit
that referenced
this pull request
Jun 5, 2013
beat me to it! Thanks |
|
Thank you both! I really appreciate the promptness. Also, hi @davedash! I miss you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of basic problems I have with tower:
r?