Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak with MP3 cover images #111

Closed
krishty opened this issue Jun 16, 2019 · 1 comment
Closed

Memory leak with MP3 cover images #111

krishty opened this issue Jun 16, 2019 · 1 comment

Comments

@krishty
Copy link

@krishty krishty commented Jun 16, 2019

I let my MPC play MP3 overnight, and this morning I was surprised to find its working set in the order of gigabytes. After trying around a bit, I was able to reproduce the issue:

  1. Play an MP3 file with an embedded cover image.
  2. Add another MP3 file with an embedded cover image to the playlist (it can be the same file.)
  3. Every time you press "forward" (or when the next file is played automatically, if you’re patient), MPC's working set grows by ~0.5–2 MiB (depending on the specific file).

This does not happen if there are no cover images in the MP3, so I suspect there is a memory leak in the cover handling …

@adipose

This comment has been minimized.

Copy link

@adipose adipose commented Dec 29, 2019

Fixed in #191

@clsid2 clsid2 closed this Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.