Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandas as a dependency #879

Closed
diyclassics opened this Issue Mar 1, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@diyclassics
Copy link
Contributor

diyclassics commented Mar 1, 2019

pandas is only used in the IndianSyllabifier and only for reading a csv file before its data in converted to a numpy array. pandas is also the largest external dependency (e.g. slowest to install in travis-ci). The csv reading and conversion to numpy can be done with the standard libraries, spec. csv

diyclassics added a commit to diyclassics/cltk that referenced this issue Mar 1, 2019

@kylepjohnson kylepjohnson self-assigned this Mar 1, 2019

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Mar 1, 2019

I remember this code and can do it.

@diyclassics

This comment has been minimized.

Copy link
Contributor Author

diyclassics commented Mar 1, 2019

@kylepjohnson Already did it. Just documenting it. Just waiting for my travis build to pass.

@diyclassics

This comment has been minimized.

Copy link
Contributor Author

diyclassics commented Mar 1, 2019

I don't notice any speed difference, etc. with the new code fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.