New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods for Akkadian nouns #569

Merged
merged 4 commits into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@willismonroe
Member

willismonroe commented Aug 14, 2017

Still getting the hang of working with this material locally and pushing remotely. Curious how the tests will fare.

This is a bunch of methods to work with Akkadian nouns. The bound form and stemmer are both useful helper functions later on when working with suffixed pronouns. The CV Pattern will be a useful function for verbs as well.

Finally the decliner is rather simple in constructions, but spits out a declined noun given any input form. This can be used to both decliner nouns, and identify their form (by declining them and matching the form and reading its attributes).

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 14, 2017

Codecov Report

Merging #569 into master will decrease coverage by 0.16%.
The diff coverage is 78.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   85.68%   85.52%   -0.17%     
==========================================
  Files         113      117       +4     
  Lines        6824     6990     +166     
==========================================
+ Hits         5847     5978     +131     
- Misses        977     1012      +35
Impacted Files Coverage Δ
cltk/tests/test_stem.py 99.58% <100%> (+0.05%) ⬆️
cltk/stem/akkadian/bound_form.py 45% <45%> (ø)
cltk/stem/akkadian/stem.py 76% <76%> (ø)
cltk/stem/akkadian/declension.py 83.78% <83.78%> (ø)
cltk/stem/akkadian/cv_pattern.py 97.22% <97.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f44816...6f9dffd. Read the comment docs.

codecov-io commented Aug 14, 2017

Codecov Report

Merging #569 into master will decrease coverage by 0.16%.
The diff coverage is 78.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   85.68%   85.52%   -0.17%     
==========================================
  Files         113      117       +4     
  Lines        6824     6990     +166     
==========================================
+ Hits         5847     5978     +131     
- Misses        977     1012      +35
Impacted Files Coverage Δ
cltk/tests/test_stem.py 99.58% <100%> (+0.05%) ⬆️
cltk/stem/akkadian/bound_form.py 45% <45%> (ø)
cltk/stem/akkadian/stem.py 76% <76%> (ø)
cltk/stem/akkadian/declension.py 83.78% <83.78%> (ø)
cltk/stem/akkadian/cv_pattern.py 97.22% <97.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f44816...6f9dffd. Read the comment docs.

@kylepjohnson

This comment has been minimized.

Show comment
Hide comment
@kylepjohnson

kylepjohnson Aug 14, 2017

Member

@willismonroe The code clean and the test coverage is good (they pass, too). So I'm happy.

I recommend updating the Akkadian docs now, too, before too much time passes. I will push all of this to PyPI as soon as I can, once the docs are in place.

Member

kylepjohnson commented Aug 14, 2017

@willismonroe The code clean and the test coverage is good (they pass, too). So I'm happy.

I recommend updating the Akkadian docs now, too, before too much time passes. I will push all of this to PyPI as soon as I can, once the docs are in place.

@kylepjohnson kylepjohnson merged commit 2968792 into cltk:master Aug 14, 2017

1 of 3 checks passed

codecov/patch 78.91% of diff hit (target 85.68%)
Details
codecov/project 85.52% (-0.17%) compared to 9f44816
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment