New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning alphabet.py module for Classical Arabic #583

Merged
merged 6 commits into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@LBenzahia
Member

LBenzahia commented Sep 26, 2017

@kylepjohnson , I've removed "u" symbol from strings incorpus/alphabet.py and make it fits with python3.6. I'll use it in the implementation of the stemmers
issue #555

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 26, 2017

Codecov Report

Merging #583 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   86.19%   86.18%   -0.01%     
==========================================
  Files         131      131              
  Lines        8219     8217       -2     
==========================================
- Hits         7084     7082       -2     
  Misses       1135     1135
Impacted Files Coverage Δ
cltk/corpus/arabic/alphabet.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfce73b...a3a63ff. Read the comment docs.

codecov-io commented Sep 26, 2017

Codecov Report

Merging #583 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   86.19%   86.18%   -0.01%     
==========================================
  Files         131      131              
  Lines        8219     8217       -2     
==========================================
- Hits         7084     7082       -2     
  Misses       1135     1135
Impacted Files Coverage Δ
cltk/corpus/arabic/alphabet.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfce73b...a3a63ff. Read the comment docs.

@kylepjohnson

👍

If you are ever curious about Python formatting, try the pylint tool -- I have found it helpful at times.

@kylepjohnson kylepjohnson merged commit 16ce7d6 into cltk:master Sep 27, 2017

3 checks passed

codecov/patch 100% of diff hit (target 86.19%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +13.8% compared to dfce73b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LBenzahia

This comment has been minimized.

Show comment
Hide comment
@LBenzahia

LBenzahia Sep 28, 2017

Member

It's helpful tool, Thanks a lot.

Member

LBenzahia commented Sep 28, 2017

It's helpful tool, Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment