New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Macron Issue in Latin Syllabifier #611

Merged
merged 3 commits into from Dec 1, 2017

Conversation

Projects
None yet
3 participants
@TylerKirby
Member

TylerKirby commented Dec 1, 2017

resolve #610

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 1, 2017

Codecov Report

Merging #611 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage    86.4%   86.47%   +0.06%     
==========================================
  Files         135      135              
  Lines        8318     8330      +12     
==========================================
+ Hits         7187     7203      +16     
+ Misses       1131     1127       -4
Impacted Files Coverage Δ
cltk/stem/latin/syllabifier.py 85.71% <ø> (+7.14%) ⬆️
cltk/tests/test_stem.py 99.61% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a74449...d3f91b1. Read the comment docs.

codecov-io commented Dec 1, 2017

Codecov Report

Merging #611 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage    86.4%   86.47%   +0.06%     
==========================================
  Files         135      135              
  Lines        8318     8330      +12     
==========================================
+ Hits         7187     7203      +16     
+ Misses       1131     1127       -4
Impacted Files Coverage Δ
cltk/stem/latin/syllabifier.py 85.71% <ø> (+7.14%) ⬆️
cltk/tests/test_stem.py 99.61% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a74449...d3f91b1. Read the comment docs.

@kylepjohnson

Easy enough solution. But please do keep a lookout for any combining/precomposed issues :)

@kylepjohnson kylepjohnson merged commit 3d15600 into cltk:master Dec 1, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kylepjohnson

This comment has been minimized.

Show comment
Hide comment
@kylepjohnson

kylepjohnson Dec 1, 2017

Member

FYI triggered new build to be sent off to PyPI: 0fc9274

In the future, whenever you feel strong about your commit, go ahead and bump the vers, too.

Member

kylepjohnson commented Dec 1, 2017

FYI triggered new build to be sent off to PyPI: 0fc9274

In the future, whenever you feel strong about your commit, go ahead and bump the vers, too.

@TylerKirby

This comment has been minimized.

Show comment
Hide comment
@TylerKirby

TylerKirby Dec 2, 2017

Member

Thanks Kyle! Will bump vers in the future and keep my eyes out for any issues with precomposed chars.

Member

TylerKirby commented Dec 2, 2017

Thanks Kyle! Will bump vers in the future and keep my eyes out for any issues with precomposed chars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment