New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swadesh list for Phoenician #736

Merged
merged 8 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@SatyarthV
Contributor

SatyarthV commented Mar 10, 2018

Added swadesh list for phoenician
Addresses #652

Update swadesh.py
Added swadesh list for phoenician

@SatyarthV SatyarthV changed the title from Update swadesh.py to Add Swadesh list for Phoenician Mar 10, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 10, 2018

Codecov Report

Merging #736 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   89.37%   89.37%   +<.01%     
==========================================
  Files         183      183              
  Lines       11527    11528       +1     
==========================================
+ Hits        10302    10303       +1     
  Misses       1225     1225
Impacted Files Coverage Δ
cltk/corpus/swadesh.py 97.43% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b184b7...e1e62d8. Read the comment docs.

codecov-io commented Mar 10, 2018

Codecov Report

Merging #736 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   89.37%   89.37%   +<.01%     
==========================================
  Files         183      183              
  Lines       11527    11528       +1     
==========================================
+ Hits        10302    10303       +1     
  Misses       1225     1225
Impacted Files Coverage Δ
cltk/corpus/swadesh.py 97.43% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b184b7...e1e62d8. Read the comment docs.

@kylepjohnson

Too short.

In [10]: len(swadesh_phn)
Out[10]: 290

In the table in the article, if there is a blank line, then add here an empty string (''). The index of items in a Swadesh list is important.

SatyarthV and others added some commits Mar 10, 2018

Update swadesh.py
Adjusting the length of the list to 320 .
@clemsciences

This comment has been minimized.

Show comment
Hide comment
@clemsciences

clemsciences Jul 11, 2018

Member
>>>len(swadesh_phn)
320

So it seems correct!

Member

clemsciences commented Jul 11, 2018

>>>len(swadesh_phn)
320

So it seems correct!

clemsciences added some commits Jul 13, 2018

@clemsciences

I think it respects the swadesh list conditions (len(swadesh_phn) == 320)

@kylepjohnson

Thanks for this :)

@kylepjohnson kylepjohnson merged commit 3032ac4 into cltk:master Sep 13, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kylepjohnson kylepjohnson referenced this pull request Sep 13, 2018

Closed

Add phoenician docs #828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment