New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt for Python 3.7 and out-of-box test success #832

Merged
merged 32 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@free-variation
Contributor

free-variation commented Sep 19, 2018

This refers also to #792

A newer point release in the Python CRF suite builds correctly, so 3.7 should now be usable.
While at it, I added to requirements.txt modules that are needed to successfully run the unit tests.

The documentation for installation from source is updated to reflect the sequence that enables tests to pass without manually installing dependencies.

Tested on Mac OS X and Win 10+Linux subsystem.

Question: why does my fork show that I'm a load of commits ahead of upstream, even though my latest was merged?

free-variation and others added some commits Jul 31, 2018

@free-variation

This comment has been minimized.

Show comment
Hide comment
@free-variation

free-variation Sep 19, 2018

Contributor

Data class here we come! Reminds me of the JavaBeans mechanism of old.

Contributor

free-variation commented Sep 19, 2018

Data class here we come! Reminds me of the JavaBeans mechanism of old.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 19, 2018

Codecov Report

Merging #832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         183      183           
  Lines       11600    11600           
=======================================
  Hits        10375    10375           
  Misses       1225     1225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe0c6e...113435a. Read the comment docs.

codecov-io commented Sep 19, 2018

Codecov Report

Merging #832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         183      183           
  Lines       11600    11600           
=======================================
  Hits        10375    10375           
  Misses       1225     1225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe0c6e...113435a. Read the comment docs.

@kylepjohnson

This comment has been minimized.

Show comment
Hide comment
@kylepjohnson

kylepjohnson Sep 19, 2018

Member
Member

kylepjohnson commented Sep 19, 2018

@kylepjohnson

This comment has been minimized.

Show comment
Hide comment
@kylepjohnson

kylepjohnson Sep 19, 2018

Member

Question: why does my fork show that I'm a load of commits ahead of upstream, even though my latest was merged?

Don't know, but I noticed this on my own branch recently. Will keep my eye on it for my own next PR. Anyways, I'll squash all the extra commits and it'll be fine.

Member

kylepjohnson commented Sep 19, 2018

Question: why does my fork show that I'm a load of commits ahead of upstream, even though my latest was merged?

Don't know, but I noticed this on my own branch recently. Will keep my eye on it for my own next PR. Anyways, I'll squash all the extra commits and it'll be fine.

@kylepjohnson kylepjohnson merged commit 4d97a80 into cltk:master Sep 20, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 7fe0c6e...113435a
Details
codecov/project 89.43% remains the same compared to 7fe0c6e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment