New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of verse module for MHG #838

Merged
merged 6 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@Sedictious
Contributor

Sedictious commented Oct 1, 2018

This adds the basic Verse module for MHG along with a primitive rhyme checker. While the rhyme checker could theoretically be somewhat accurate once a phonetical algo is implemented (I'll try to be done with it soon), a metrical scanner poses a far greater challenge. Is someone aware of any methods utilizing NN?

Sedictious added some commits Oct 1, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 1, 2018

Codecov Report

Merging #838 into master will increase coverage by 0.03%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
+ Coverage   89.43%   89.47%   +0.03%     
==========================================
  Files         183      184       +1     
  Lines       11600    11627      +27     
==========================================
+ Hits        10375    10403      +28     
+ Misses       1225     1224       -1
Impacted Files Coverage Δ
cltk/prosody/middle_high_german/verse.py 92.59% <92.59%> (ø)
cltk/phonology/middle_high_german/transcription.py 97.4% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed62b4...2332e3a. Read the comment docs.

codecov-io commented Oct 1, 2018

Codecov Report

Merging #838 into master will increase coverage by 0.03%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
+ Coverage   89.43%   89.47%   +0.03%     
==========================================
  Files         183      184       +1     
  Lines       11600    11627      +27     
==========================================
+ Hits        10375    10403      +28     
+ Misses       1225     1224       -1
Impacted Files Coverage Δ
cltk/prosody/middle_high_german/verse.py 92.59% <92.59%> (ø)
cltk/phonology/middle_high_german/transcription.py 97.4% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed62b4...2332e3a. Read the comment docs.

kylepjohnson added some commits Oct 4, 2018

@kylepjohnson kylepjohnson merged commit f1bc09b into cltk:master Oct 4, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment