New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop module update #840

Merged
merged 35 commits into from Oct 11, 2018

Conversation

Projects
3 participants
@diyclassics
Contributor

diyclassics commented Oct 11, 2018

This PR:

  1. introduces a generalizable method for constructing stoplists (i.e. CorpusStoplist in cltk.stop.stop)
  2. two examples of language-specific subclasses of CorpusStoplist (cf. cltk.stop.latin)
  3. Tests & docs

(Closes #743 with thanks to @kevinstadler)

@diyclassics diyclassics added this to To do in latin-core via automation Oct 11, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 11, 2018

Codecov Report

Merging #840 into master will decrease coverage by 0.09%.
The diff coverage is 82.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #840     +/-   ##
=========================================
- Coverage   89.47%   89.38%   -0.1%     
=========================================
  Files         184      185      +1     
  Lines       11627    11641     +14     
=========================================
+ Hits        10403    10405      +2     
- Misses       1224     1236     +12
Impacted Files Coverage Δ
cltk/lemmatize/latin/backoff.py 96.95% <ø> (+0.48%) ⬆️
cltk/vector/word2vec.py 18.51% <100%> (ø) ⬆️
cltk/stem/latin/stem.py 84.21% <100%> (ø) ⬆️
cltk/stop/classical_chinese.py 35.29% <35.29%> (ø)
cltk/stop/latin.py 87.5% <87.5%> (ø)
cltk/tests/test_nlp/test_stop.py 97.67% <90.9%> (-2.33%) ⬇️
cltk/stop/stop.py 93.66% <93.1%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bc09b...efd7dc5. Read the comment docs.

@kylepjohnson

Good, but someone needs to rerun cltk/utils/contributors.py to create contributors.md.

@kylepjohnson kylepjohnson merged commit 9deebf3 into cltk:master Oct 11, 2018

1 of 3 checks passed

codecov/patch 82.4% of diff hit (target 89.47%)
Details
codecov/project 89.38% (-0.1%) compared to f1bc09b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

latin-core automation moved this from To do to Done Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment