New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes _long_by_nature method of Greek Scansion class to check for double_consonants #869

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@siddharthkv7
Copy link
Contributor

siddharthkv7 commented Feb 6, 2019

Fixes #790 . Checks for double consonants as well, in the long_by_nature method.
@TylerKirby , please review :)

siddharthkv7 added some commits Feb 6, 2019

@siddharthkv7 siddharthkv7 changed the title Fixes "long by nature" method of Greek Scansion class Fixes _long_by_nature method of Greek Scansion class to check for double_consonants Feb 6, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #869 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         191      191           
  Lines       12264    12264           
=======================================
  Hits        10996    10996           
  Misses       1268     1268
Impacted Files Coverage Δ
cltk/prosody/greek/scanner.py 94.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093e433...66fb393. Read the comment docs.

@kylepjohnson kylepjohnson requested a review from TylerKirby Feb 6, 2019

@TylerKirby
Copy link
Member

TylerKirby left a comment

Easy enough. I just double checked to make sure this fixed the original issue and everything looks good!

@TylerKirby TylerKirby merged commit b5b23cc into cltk:master Feb 8, 2019

3 checks passed

codecov/patch 100% of diff hit (target 89.66%)
Details
codecov/project 89.66% (+0%) compared to 093e433
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment