Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas check; fixes #879 #880

Merged
merged 16 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@diyclassics
Copy link
Contributor

diyclassics commented Mar 2, 2019

Removes pandas dependency with (seemingly—fingers crossed!) no change in functionality; uses csv and list comprehensions. All tests pass at least.

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Mar 2, 2019

Ahh, so you removed even the need for it? Got it, I like this.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #880 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage   89.66%   89.66%   +<.01%     
==========================================
  Files         191      191              
  Lines       12264    12272       +8     
==========================================
+ Hits        10996    11004       +8     
  Misses       1268     1268
Impacted Files Coverage Δ
cltk/tests/test_nlp/test_corpus.py 97.71% <ø> (ø) ⬆️
cltk/tests/test_nlp/test_stem.py 100% <100%> (ø) ⬆️
cltk/stem/sanskrit/indian_syllabifier.py 88.49% <93.33%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6b6be...ec1b84b. Read the comment docs.

@kylepjohnson kylepjohnson merged commit 47f00b5 into cltk:master Mar 2, 2019

3 checks passed

codecov/patch 94.73% of diff hit (target 89.66%)
Details
codecov/project 89.66% (+<.01%) compared to 4b6b6be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diyclassics diyclassics deleted the diyclassics:pandas-check branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.