Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time nose #898

Merged
merged 4 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@kylepjohnson
Copy link
Member

commented Apr 4, 2019

Trying out the basic use of nose-timer. If this doesn't cluttering the output, wouldn't hurt to have it in here long term.

There's also a way to force a failure of a test which runs more than n seconds -- could be a preventative against something like this in the future.

Johnson, Kyle P added some commits Apr 2, 2019

Johnson, Kyle P
update travis to use xenial
> 3.7 not available on default Ubuntu/travis builds, so using
instructions here: https://docs.travis-ci.com/user/languages/python/ to
update us to 3.7 (while keeping 3.6) and maybe later pre-release dev
builds
Johnson, Kyle P

@kylepjohnson kylepjohnson requested a review from diyclassics Apr 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         206      206           
  Lines       14053    14053           
=======================================
  Hits        12595    12595           
  Misses       1458     1458

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb0923...6ceefbc. Read the comment docs.

@kylepjohnson kylepjohnson merged commit fb61d10 into cltk:master Apr 4, 2019

3 checks passed

codecov/patch Coverage not affected when comparing beb0923...6ceefbc
Details
codecov/project 89.62% remains the same compared to beb0923
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kylepjohnson kylepjohnson deleted the kylepjohnson:time-nose branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.