Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #899

Merged
merged 11 commits into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@diyclassics
Copy link
Contributor

diyclassics commented Apr 4, 2019

Working on #897—my last build on Travis with this setup was < 21 mins.
Screen Shot 2019-04-04 at 2 50 21 PM

@diyclassics diyclassics requested a review from todd-cook Apr 4, 2019

@diyclassics

This comment has been minimized.

Copy link
Contributor Author

diyclassics commented Apr 4, 2019

@todd-cook You should check the changes I made to the corpus reader and filtered corpus reader tests; main notes: 1. used a much smaller test text; 2. removed some list calls; 3. tested for only one filtered word (instead of two).

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #899 into master will increase coverage by <.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   89.62%   89.63%   +<.01%     
==========================================
  Files         206      206              
  Lines       14053    14043      -10     
==========================================
- Hits        12595    12587       -8     
+ Misses       1458     1456       -2
Impacted Files Coverage Δ
cltk/corpus/odia/alphabet.py 100% <ø> (ø) ⬆️
cltk/tests/test_nlp/test_phonology.py 100% <100%> (ø) ⬆️
cltk/tests/test_corpus/test_corpus.py 98.03% <88.67%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb61d10...cd7d1f4. Read the comment docs.

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Apr 4, 2019

Ran for 17 min 59 sec! https://travis-ci.org/cltk/cltk/jobs/515862742#L2265

@diyclassics do you want to keep working on this branch? Or that I merge now?

@diyclassics

This comment has been minimized.

Copy link
Contributor Author

diyclassics commented Apr 4, 2019

Your call—might be better if I open up individual issues for refactoring each test suite.

@kylepjohnson kylepjohnson merged commit ed1a241 into cltk:master Apr 4, 2019

3 checks passed

codecov/patch 90.47% of diff hit (target 89.62%)
Details
codecov/project 89.63% (+<.01%) compared to fb61d10
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.