Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed authors' email addresses for contributors.md #913

Merged
merged 5 commits into from Jun 1, 2019

Conversation

Projects
None yet
3 participants
@clemsciences
Copy link
Member

commented May 22, 2019

When I approved the #910 pull request, I didn't see that there were typos in authors' names and email addresses.
So I fixed authors' email addresses for contributors.md. I alsoo modified contributors.py so that it may be run from a Unix or Windows OS. Finally, I changed some ''' into """ for docstrings.

Fixed authors' email addresses for contributors.md and contributors.p…
…y may be run from a Unix or Windows OS.
@codecov-io

This comment has been minimized.

Copy link

commented May 22, 2019

Codecov Report

Merging #913 into master will not change coverage.
The diff coverage is 89.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         221      221           
  Lines       14237    14237           
=======================================
  Hits        12777    12777           
  Misses       1460     1460
Impacted Files Coverage Δ
cltk/stop/punjabi/stops.py 100% <ø> (ø) ⬆️
cltk/tokenize/old_french/params.py 100% <ø> (ø) ⬆️
cltk/tokenize/arabic/word.py 100% <ø> (ø) ⬆️
cltk/tokenize/sentence.py 88.88% <ø> (ø) ⬆️
cltk/tests/test_nlp/test_stem.py 99.31% <ø> (ø) ⬆️
cltk/tokenize/word.py 90.21% <ø> (ø) ⬆️
cltk/tests/test_akkadian/test_akkadian.py 100% <ø> (ø) ⬆️
cltk/tokenize/akkadian/word.py 62.5% <ø> (ø) ⬆️
cltk/tokenize/old_french/word.py 100% <ø> (ø) ⬆️
cltk/utils/file_operations.py 88.57% <100%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f173fdc...6e15feb. Read the comment docs.

clemsciences added some commits May 22, 2019

@clemsciences

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

So adding useless imports increases code coverage... This is really annoying.

@clemsciences clemsciences requested a review from kylepjohnson May 23, 2019

clemsciences and others added some commits May 25, 2019

Rm encoding on file open
We don't support windows, so this isn't necessary for us
@kylepjohnson
Copy link
Member

left a comment

Thx it must have take time to go through every __author__

@kylepjohnson kylepjohnson merged commit 77192ba into cltk:master Jun 1, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.