Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error tests for custom cltk_data dir #919

Merged
merged 5 commits into from Jun 10, 2019

Conversation

Projects
None yet
3 participants
@kylepjohnson
Copy link
Member

commented Jun 9, 2019

Coming from discussion at end of #917

Test method here: https://github.com/cltk/cltk/pull/919/files#diff-2c2062383e58d19e5892cd202a756f27R163

@fractaledmind This gives 100% coverage to cltk/__init__.py. We use this manner of asserting errors elsewhere in the tests.

Open to feedback if I did not understand your last comment.

Travis CI added some commits Jun 9, 2019

Travis CI
Travis CI
@codecov-io

This comment has been minimized.

Copy link

commented Jun 9, 2019

Codecov Report

Merging #919 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   89.74%   89.76%   +0.01%     
==========================================
  Files         221      221              
  Lines       14243    14260      +17     
==========================================
+ Hits        12783    12801      +18     
+ Misses       1460     1459       -1
Impacted Files Coverage Δ
cltk/tests/test_nlp/test_stem.py 99.31% <ø> (ø) ⬆️
cltk/__init__.py 100% <100%> (+5.26%) ⬆️
cltk/tests/test_nlp/test_phonology.py 100% <100%> (ø) ⬆️
cltk/tests/test_nlp/test_utils.py 96.61% <100%> (+0.41%) ⬆️
cltk/tests/test_corpus/test_corpus.py 98.04% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18f289...0342963. Read the comment docs.

@almostearthling
Copy link
Contributor

left a comment

Looks good to me!

@kylepjohnson kylepjohnson merged commit 0da0df6 into cltk:master Jun 10, 2019

3 checks passed

codecov/patch 100% of diff hit (target 89.74%)
Details
codecov/project 89.76% (+0.01%) compared to a18f289
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kylepjohnson kylepjohnson deleted the kylepjohnson:os-var-test branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.