Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthophonology reformatting #923

Merged
merged 3 commits into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@clemsciences
Copy link
Member

commented Jul 3, 2019

This is mainly some reformatting of Python modules. I added a geminate function which may be useful for Consonant instances (like the lengthen method for Vowel instances).

@kylepjohnson kylepjohnson self-requested a review Jul 3, 2019

@kylepjohnson

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Looks PEP-8-ish, which is nice. I'll merge this one once the build passes.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #923 into master will increase coverage by <.01%.
The diff coverage is 94.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   89.78%   89.79%   +<.01%     
==========================================
  Files         221      221              
  Lines       14267    14281      +14     
==========================================
+ Hits        12810    12823      +13     
- Misses       1457     1458       +1
Impacted Files Coverage Δ
cltk/tests/test_nlp/test_orthophonology.py 100% <100%> (+0.89%) ⬆️
cltk/phonology/old_english/orthophonology.py 100% <100%> (ø) ⬆️
cltk/phonology/orthophonology.py 89.84% <89.84%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec314f...7c910f9. Read the comment docs.

@kylepjohnson kylepjohnson merged commit 0705b8f into cltk:master Jul 3, 2019

3 checks passed

codecov/patch 94.18% of diff hit (target 89.78%)
Details
codecov/project 89.79% (+<.01%) compared to eec314f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.