Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and formatting fixes for WordTokenizer #932

Merged
merged 3 commits into from Aug 21, 2019

Conversation

@kylepjohnson
Copy link
Member

commented Aug 17, 2019

  1. Simple pylint cleanup of the word.py file, plus logging a warning that french defaults to old_french.

  2. I would like to point out the following pylint warnings coming out of the BaseWordTokenizer, and what if anything should be done about them:

$ pylint cltk/tokenize/word.py 
************* Module cltk.tokenize.word
cltk/tokenize/word.py:127:8: W0107: Unnecessary pass statement (unnecessary-pass)
cltk/tokenize/word.py:146:4: W0221: Parameters differ from overridden 'tokenize' method (arguments-differ)
cltk/tokenize/word.py:171:4: W0221: Parameters differ from overridden 'tokenize' method (arguments-differ)
cltk/tokenize/word.py:198:4: W0221: Parameters differ from overridden 'tokenize' method (arguments-differ)

@kylepjohnson kylepjohnson requested review from todd-cook and diyclassics Aug 17, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 17, 2019

Codecov Report

Merging #932 into master will increase coverage by <.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   89.77%   89.77%   +<.01%     
==========================================
  Files         222      222              
  Lines       14254    14258       +4     
==========================================
+ Hits        12796    12800       +4     
  Misses       1458     1458
Impacted Files Coverage Δ
cltk/tokenize/word.py 95.55% <88.23%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697bfca...39c3947. Read the comment docs.

@todd-cook
Copy link
Contributor

left a comment

Looks good! Thanks for doing this!

@kylepjohnson kylepjohnson merged commit c2b6041 into cltk:master Aug 21, 2019

2 of 3 checks passed

codecov/patch 88.23% of diff hit (target 89.77%)
Details
codecov/project 89.77% (+<.01%) compared to 697bfca
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.