Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swadesh list for Coptic #959

Merged
merged 7 commits into from Nov 16, 2019
Merged

Add Swadesh list for Coptic #959

merged 7 commits into from Nov 16, 2019

Conversation

@nolanee
Copy link
Contributor

nolanee commented Nov 15, 2019

#956

I chose to use a list of strings when there were synonyms, otherwise each entry is a single string.

@kylepjohnson kylepjohnson self-requested a review Nov 15, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #959 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   89.78%   89.79%   +0.01%     
==========================================
  Files         222      223       +1     
  Lines       14270    14288      +18     
==========================================
+ Hits        12812    12830      +18     
  Misses       1458     1458
Impacted Files Coverage Δ
cltk/tests/test_languages/test_coptic.py 100% <100%> (ø)
cltk/corpus/swadesh.py 97.61% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc3ffd...ca28caa. Read the comment docs.

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Nov 15, 2019

I'm ready to merge this, but would prefer @nolanee that you add some docs here, first: https://github.com/cltk/cltk/blob/master/docs/coptic.rst

You may use old norse as a pattern: https://github.com/cltk/cltk/blob/master/docs/old_norse.rst#swadesh

I would have mentioned this earlier, had I known you'd be so fast!

@kylepjohnson kylepjohnson merged commit f6bc71b into cltk:master Nov 16, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 89.78%)
Details
codecov/project 89.79% (+0.01%) compared to 7bc3ffd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kylepjohnson added a commit that referenced this pull request Nov 16, 2019
PR #959 by @nolanee Edward Nolan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.