New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always scroll to the top #2

Closed
extesy opened this Issue Mar 18, 2013 · 4 comments

Comments

Projects
None yet
4 participants
@extesy

extesy commented Mar 18, 2013

When the intro'ed control is already entirely visible on the screen, there's no need to scroll it to the very top. Otherwise on the vertically oriented (or just big enough) screens it becomes very inconvenient to read.

@clu3

This comment has been minimized.

Show comment
Hide comment
@clu3

clu3 Mar 21, 2013

Owner

@extesy that's true I agree. I'll handle this when I have some more free time. Cheers

Owner

clu3 commented Mar 21, 2013

@extesy that's true I agree. I'll handle this when I have some more free time. Cheers

@jcorreia

This comment has been minimized.

Show comment
Hide comment
@jcorreia

jcorreia Mar 21, 2013

Hi, I have this same problem.
Im using bootstrap with a nav bar and as it scrolls to the top, part of the popover title hides behind the navbar.

Thanks

jcorreia commented Mar 21, 2013

Hi, I have this same problem.
Im using bootstrap with a nav bar and as it scrolls to the top, part of the popover title hides behind the navbar.

Thanks

clu3 pushed a commit that referenced this issue May 27, 2013

Steve Tran
1. fixed issue #2: Dont always scroll to top, if the element is entir…
…ely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
@clu3

This comment has been minimized.

Show comment
Hide comment
@clu3

clu3 May 27, 2013

Owner

@extesy @jcorreia I've fixed the problem with the above commit,cheers

Owner

clu3 commented May 27, 2013

@extesy @jcorreia I've fixed the problem with the above commit,cheers

@clu3 clu3 referenced this issue May 27, 2013

Open

navbar-fixed-top #15

@clu3 clu3 closed this Jun 3, 2013

tsrivishnu added a commit to tsrivishnu/bootstro.js that referenced this issue Sep 28, 2013

1. fixed issue clu3#2: Dont always scroll to top, if the element is e…
…ntirely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin

tsrivishnu added a commit to tsrivishnu/bootstro.js that referenced this issue Sep 28, 2013

1. fixed issue clu3#2: Dont always scroll to top, if the element is e…
…ntirely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
@elegantnodejs

This comment has been minimized.

Show comment
Hide comment
@elegantnodejs

elegantnodejs commented Jan 27, 2015

good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment