[Spec 0042] Namespace tmux sessions with project name#75
Merged
Conversation
Prevents cross-project collisions when multiple projects have same spec numbers.
Session naming changed from:
builder-{spec_id} → builder-{project}-{spec_id}
Example:
builder-0041 → builder-codev-0041
This prevents project A from accidentally killing project B's builder session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder-{spec_id}→builder-{project}-{spec_id}Problem
When two projects (e.g., codev and ansari) both had spec 0041, their builders shared the same tmux session name
builder-0041. This caused one project to accidentally kill the other's builder.Solution
Namespace session names with the project directory name:
builder-codev-0041(codev project)builder-ansari-0041(ansari project)Test Plan
builder-codev-0041