Apache resource agent issues: grep exit code and improper OCF_CHECK_LEVEL usage

[Alan-R]

In the apache resource agent, the code uses the exit code from grep directly - as though it were a proper OCF exit code. It is not.

This causes a "not running" condition to become "generic error" - which is not right. Pacemaker treats the two very differently.

The second problem is the non-conforming implementation of OCF_CHECK_LEVEL. The OCF specification states that if you receive an OCF_CHECK_LEVEL that you do not support, you are to treat it as the next lower level that you do support - and you're required to support OCF_CHECK_LEVEL of 0. In effect, this means that any positive OCF_CHECK_LEVEL is legal for any resource agent - unlike this implementation of the apache agent, which allows only one value.

[fghaas]

Thanks Alan, makes perfect sense. Do you have the time and inclination to hack up a patch, or would you prefer that someone else do that?

[dmuhamedagic]

On Tue, Aug 28, 2012 at 06:54:13AM -0700, Alan Robertson wrote:

In the apache resource agent, the code uses the exit code from grep directly - as though it were a proper OCF exit code. It is not.

This causes a "not running" condition to become "generic error" - which is not right. Pacemaker treats the two very differently.

The second problem is the non-conforming implementation of OCF_CHECK_LEVEL. The OCF specification states that if you receive an OCF_CHECK_LEVEL that you do not support, you are to treat it as the next lower level that you do support - and you're required to support OCF_CHECK_LEVEL of 0. In effect, this means that any positive OCF_CHECK_LEVEL is legal for any resource agent - unlike this implementation of the apache agent, which allows only one value.

Hi Alan, just replied to your email to the linux-ha-dev ML. I
guess we can keep the discussion to one place :)

[dmuhamedagic]

Both issues fixed now. Thanks for reporting!