Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0 Custom rules fixes #154 #165

Merged
merged 24 commits into from Oct 11, 2013

Conversation

Projects
None yet
2 participants
@AsaAyers
Copy link
Collaborator

AsaAyers commented Oct 7, 2013

An update to gh-pages is in a different pull request. This PR is mostly about getting the attention of anyone interested in reviewing or commenting before I merge this.

Will this affect my existing config?

No, everything here is backward compatible. It contains all of the same rules and passes the same tests.

What's new?

  • In your config file you can set a module the same way you would set a level
  • coffeelint.registerRule(RuleConstructor) for loading rules when you aren't using the command line.
  • The command line has a new --rules parameter that can specify a NodeJS module to load a custom rule.
  • CoffeeLint uses Browserify at build-time, but introduces NO new runtime dependencies.

Simple example of loading a custom rule from your config file:

{
    "fibonacci_indentation": {
        "module": "coffeelint-fibonacci"
    }
}

Asa Ayers added some commits Aug 14, 2013

Asa Ayers Asa Ayers
Changed the terminology from Plugins to Rules.
The only valid plugin is a rule, and every rule will be implemented as a
plugin.
Asa Ayers Asa Ayers
Restored the test for newlines_after_classes and fixed the errors. I …
…didn't intent to leave the test commented out.

@AsaAyers AsaAyers referenced this pull request Oct 7, 2013

Merged

Gh pages 0.6 #166

@AsaAyers

This comment has been minimized.

Copy link
Collaborator Author

AsaAyers commented Oct 7, 2013

@clutchski How important do you consider NodeJS 0.6 compatibility? One of the new dependencies (coffeeify) doesn't seem to support it, but I don't know how I can get an idea of how many people may be affected.

@eventualbuddha

This comment has been minimized.

Copy link
Contributor

eventualbuddha commented Oct 7, 2013

I don't actually know the breakdown either, but 0.6 is two stable versions behind now so I'd be inclined to dump it if maintenance doesn't seem worth it. Can we tag the package in such a way that 0.6 users will get the old version and everyone else the latest?

-bd

On Oct 6, 2013, at 7:45 PM, Asa Ayers notifications@github.com wrote:

@clutchski How important do you consider NodeJS 0.6 compatibility? One of the new dependencies (coffeeify) doesn't seem to support it, but I don't know how I can get an idea of how many people may be affected.


Reply to this email directly or view it on GitHub.

Asa Ayers added some commits Oct 11, 2013

Asa Ayers Asa Ayers
Drop support for NodeJS 0.6
Coffeeify is a new dependency and for some reason TravisCI shows it
doesn't install on NodeJS 0.6.

I don't know how long TravisCI keeps these, but the failed built is
at https://travis-ci.org/clutchski/coffeelint/jobs/12213132
Asa Ayers Asa Ayers
Merge branch 'master' into custom-rules
Conflicts:
	src/coffeelint.coffee

AsaAyers added a commit that referenced this pull request Oct 11, 2013

@AsaAyers AsaAyers merged commit 28b9e3f into master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details

@AsaAyers AsaAyers deleted the custom-rules branch Oct 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.