New --stdin flag #17

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

sjz commented Mar 15, 2012

--stdin flag added to allow piping

I got impatient for this as I needed it for part of the sublimelinter thingo I'm working on.

That is all :)

Owner

clutchski commented Mar 15, 2012

Very cool stuff. Thanks very much. Before merging, a couple of code review comments:

Contributor

sjz commented Mar 15, 2012

Yep - I will de-lazify my code a bit

I'll pull out the duplication to some common method or something like that

Not sure what to do once done on the github side (I am pretty new to it)..do I close this and then create another pull request or..

@sjz: just push another commit to the same branch.

edit: Ugh, wait, you opened a pull request off master. You can just push to master, I guess. Though, it's more proper to have done your work on a separate feature branch, in case you wanted to work on a separate feature, or in case this didn't get pulled but you wanted to keep your fork current.

Contributor

sjz commented Mar 16, 2012

Massive apologies for the diff on bin/coffeelint
Makes sense if you look through it..I'll markup the request

Contributor

sjz commented Mar 18, 2012

bully :(

Owner

clutchski commented Mar 18, 2012

Hey man,

I tried to merge this in, but it looks like the command line tests are failing. Can you take a pass at that and get them passing? To run them, just call rake from within the project. The tests require rake and the node dependencies.

Here's an example:

♢ commandline

  with custom configuration
    ✗ works
      » expected null, got {
    code: 127,
    killed: false,
    stack: 'Error: Command failed: env: node\\r: No such file or directory\n\n    at ChildProcess.exithandler (child_process.js:280:15)\n    at ChildProcess.<anonymous> (events.js:70:17)\n    at ChildProcess.emit (/Users/matt/code/github/coffeelint/node_modules/vows/lib/vows.js:236:24)\n    at maybeExit (child_process.js:359:16)\n    at Socket.<anonymous> (child_process.js:464:7)\n    at Socket.<anonymous> (events.js:67:17)\n    at Socket.emit (/Users/matt/code/github/coffeelint/node_modules/vows/lib/vows.js:236:24)\n    at Array.1 (net.js:314:10)\n    at EventEmitter._tickCallback (node.js:192:40)',
    message: 'Command failed: env: node\\r: No such file or directory\n',
    signal: null,
    arguments: undefined,
    type: undefined

And it's not bullying, just making sure the code is consistent across the project. Thanks.

Contributor

sjz commented Mar 18, 2012

I know it's not bullying..it's your project. Fair enough that you want it done right.

Having real problems with getting rake etc going on this windows machine. Will just have to see..

Owner

clutchski commented Mar 26, 2012

Hey,

I'm going to close this because I converted the command line tool to CoffeeScript, which has been lingering for a while. If you want to re-submit in CoffeeScript, that'd be great. Shouldn't be too big of a change. Sorry if the timing is a pain.

@clutchski clutchski closed this Mar 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment