This repository has been archived by the owner. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #540
Changes:
Changes the semantics of
coffeelint-enable
:From: enables all rules that were previously disabled by a
coffeelint-disable
directiveTo: resets the ruleset to whatever was originally specified in
coffeelint.json
This is because the current implementation is buggy and mixes immutable with mutable structures. While there are ways around this, it makes the code needlessly complex and not that much useful.
Example of existing bug
Adds the following directives that work like their parents but only for the current line
coffeelint-disable-line=foo,bar,baz
coffeelint-enable-line=foo,bar,baz
Overloads
coffeelint-disable
to disable all registered rules. Primary use case:This contrasts with the primary use case for the parametric version which is:
Adds support for directive shortcuts. Also defines the first shortcut
# noqa
that expands intocoffeelint: disable-line