Indentation strict and not strict mode. #65

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

ghost commented Sep 27, 2012

This is so we can ignore issues with coffeelint not correctly
understanding indentation, but still have a tiny little indentation
check for consistency, just that it's a multiple of what we set the
indentation value to.

This is how we fixed #64 #4 and #46 for ourselves.

I'm optimistic because we added it as an option, it might not be to problematic to pull into the core?

Derek Bredensteiner
Adding a strict mode for indentation.
This is so we can ignore issues with coffeelint not correctly
understanding indentation, but still have a tiny little indentation
check for consistency, just that it's a multiple of what we set the
indentation value to.
@thomasf

This comment has been minimized.

Show comment Hide comment
@thomasf

thomasf Nov 5, 2012

Contributor

I'm not sure.. I will look into the indentation linting code first.. If this is to be merged it needs tests and a documentation update as well.

Contributor

thomasf commented Nov 5, 2012

I'm not sure.. I will look into the indentation linting code first.. If this is to be merged it needs tests and a documentation update as well.

Add test for strict false
Uses the existing test from the indentation topic, it is only testing for indentation that is a multiple of the configured number.

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Nov 6, 2012

Not sure if that sole test I added is sufficient, I will take another stab if told it is not.

Wasn't sure where to do a documentation update, here's a gist https://gist.github.com/4022479 of a suggested modification to http://www.coffeelint.org/#options

ghost commented Nov 6, 2012

Not sure if that sole test I added is sufficient, I will take another stab if told it is not.

Wasn't sure where to do a documentation update, here's a gist https://gist.github.com/4022479 of a suggested modification to http://www.coffeelint.org/#options

@thomasf

This comment has been minimized.

Show comment Hide comment
@thomasf

thomasf Nov 6, 2012

Contributor

Great job!

Add at least one failing and an passing test.

I just began coding coffeelint yesterday myself, I modeled these tests after one of the other tests:
https://github.com/clutchski/coffeelint/blob/master/test/test_no_stand_alone_at.coffee

The thing I'm still most uncertain about is actually the wording "strict" since this relates to a possible bug it's more of a workaround.. I'll think about it and get back coffeelint later this week.

Contributor

thomasf commented Nov 6, 2012

Great job!

Add at least one failing and an passing test.

I just began coding coffeelint yesterday myself, I modeled these tests after one of the other tests:
https://github.com/clutchski/coffeelint/blob/master/test/test_no_stand_alone_at.coffee

The thing I'm still most uncertain about is actually the wording "strict" since this relates to a possible bug it's more of a workaround.. I'll think about it and get back coffeelint later this week.

@AsaAyers

This comment has been minimized.

Show comment Hide comment
@AsaAyers

AsaAyers Nov 14, 2013

Collaborator

I'm going to go ahead and close this. I'm interpreting the lack of activity here for the last year as a lack of need for non-strict mode. Indentation still isn't perfect but has been significantly improved.

Collaborator

AsaAyers commented Nov 14, 2013

I'm going to go ahead and close this. I'm interpreting the lack of activity here for the last year as a lack of need for non-strict mode. Indentation still isn't perfect but has been significantly improved.

@AsaAyers AsaAyers closed this Nov 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment