chore: add cmake to support rdkafka #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
reviewed
Oct 10, 2022
Dockerfile
Outdated
| PQ_VER="11.12" \ | ||
| SQLITE_VER="3390200" \ | ||
| CC=musl-gcc \ | ||
| CXX=g++ \ |
Owner
There was a problem hiding this comment.
i feel like this is not correct for us to be always exporting in this image as it leads to us implicitly pointing c++ to one compiler and arch (gcc with glibc) and c to another (musl-gcc against musl).
it might work for rdkafka upstream, but it might break other cpp projects wanting to build through musl-gcc. my gut feeling is that it would be better for you to set CXX in your own dockerfile
Contributor
Author
There was a problem hiding this comment.
Fair - but we can include cmake here I guess? It is after all referenced in the Dockerfile though not installed.
Owner
There was a problem hiding this comment.
cmake is reasonable to add, yeah :-)
bodymindarts
force-pushed
the
chore--support-rdkafka
branch
from
4d76b7a to
f6ab018
Compare
Contributor
Author
|
Force pushed to remove |
Owner
|
Oh, I missed the update, sorry. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build rdkafka with musl
cmakemust be installed.closes #109