From 3056e6d0394987d20ba6c363f238c4922e5cbcab Mon Sep 17 00:00:00 2001 From: Seena Fallah Date: Mon, 19 Feb 2024 22:40:12 +0100 Subject: [PATCH] PublicAccessBlock: test 404 on no block configuration Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket: Refs: https://github.com/ceph/ceph/pull/55652 Signed-off-by: Seena Fallah --- s3tests_boto3/functional/test_s3.py | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/s3tests_boto3/functional/test_s3.py b/s3tests_boto3/functional/test_s3.py index 22ed5abd..c8a09338 100644 --- a/s3tests_boto3/functional/test_s3.py +++ b/s3tests_boto3/functional/test_s3.py @@ -12590,16 +12590,22 @@ def test_get_nonpublicpolicy_deny_bucket_policy_status(): resp = client.get_bucket_policy_status(Bucket=bucket_name) assert resp['PolicyStatus']['IsPublic'] == True -def test_get_default_public_block(): - #client = get_svc_client(svc='s3control', client_config=Config(s3={'addressing_style': 'path'})) +def test_get_undefined_public_block(): bucket_name = get_new_bucket() client = get_client() - resp = client.get_public_access_block(Bucket=bucket_name) - assert resp['PublicAccessBlockConfiguration']['BlockPublicAcls'] == False - assert resp['PublicAccessBlockConfiguration']['BlockPublicPolicy'] == False - assert resp['PublicAccessBlockConfiguration']['IgnorePublicAcls'] == False - assert resp['PublicAccessBlockConfiguration']['RestrictPublicBuckets'] == False + # delete the existing public access block configuration + # as AWS creates a default public access block configuration + resp = client.delete_public_access_block(Bucket=bucket_name) + assert resp['ResponseMetadata']['HTTPStatusCode'] == 204 + + response_code = "" + try: + resp = client.get_public_access_block(Bucket=bucket_name) + except ClientError as e: + response_code = e.response['Error']['Code'] + + assert response_code == 'NoSuchPublicAccessBlockConfiguration' def test_put_public_block(): #client = get_svc_client(svc='s3control', client_config=Config(s3={'addressing_style': 'path'}))