Convert var/let to let/const #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` eslint ./lib --rule 'no-var: 2' --fix ```
``` eslint ./lib --rule 'prefer-const: 2' --fix ```
``` eslint ./tests/es6 --rule 'prefer-const: 2' --fix ```
Julusian
added a commit
that referenced
this pull request
May 10, 2022
|
I have re-run those commands on master to make the change avoiding the conflicts this pr had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the usage of var/let to let/const using Eslint.
Method
Eslint parses the AST and performs scope analysis and reference counting to verify that these changes are safe.
The example of conversion for lib folder:
Benefits
Using
varresults in unwanted behavior because its scope is leaked upwards. This PR prevents these kinds of bugs. JsCodeshift already finds the cases where the conversion is not safe andvaris leaked intentionally and leaves them as is.This allows the JavaScript engine to perform better optimizations for the code