Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escaped quotes from windows registry queries #250

merged 1 commit into from Jul 22, 2021


Copy link


Scanning through the docs for child_process -- -- I can see that execFile includes a parameter controlling argument escaping, windowsVerbatimArguments, which default to false (and cmake-js does not override). This lends some additional weight to the proposed fix to remove the manually-added quotes, as execFile should take care of it for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants