New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user email to config #2

Merged
merged 1 commit into from Mar 15, 2013

Conversation

Projects
None yet
2 participants
@axemclion
Contributor

axemclion commented Mar 3, 2013

When doing npm.registry.adduser, the details do not get added to local npm.config. Username and password (with auth) are added to npm.config on the method, but not the email address. Hence, when there is no local ~/.npmrc file, npm.commands.publish is not able to find an email, and the publish fails. This is true in cases on CI (travis) where a new machine does not have a local ~/.npmrc file. This change adds the email to the npm.config, that can then be used by npm.commands.publish, to push the repository successfully.

Parashuram N
Added user email to config
When doing npm.registry.adduser, the details do not get added to local npm.config. Username and password (with auth) are added to npm.config on the method, but not the email address. Hence, when there is no local ~/.npmrc file, npm.commands.publish is not able to find an email, and the publish fails. This is true in cases on CI (travis) where a new machine does not have a local ~/.npmrc file. This change adds the email to the npm.config, that can then be used by npm.commands.publish, to push the repository successfully.

cmanzana added a commit that referenced this pull request Mar 15, 2013

Merge pull request #2 from axemclion/patch-1
Added user email to config

@cmanzana cmanzana merged commit 8b95945 into cmanzana:master Mar 15, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment